Add qualifier tests for Deployment Descriptors #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njr-11
reviewed
Jan 12, 2024
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
njr-11
reviewed
Jan 12, 2024
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
|
@njr-11 I added in alternative verification tests for lookup vs. injected Context Services and Thread Factories. |
njr-11
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks. This looks correct now. I added a comment about one area that could optionally be improved. To answer your question about how to compare ManagedExecutorServices and ManagedScheduledExecutorServices, that can be done by making assertions on the maxAsync, although that is more work and probably best done in a separate pull.
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
KyleAure
force-pushed
the
404-qualifier-tests
branch
2 times, most recently
from
60ebfc9 to
4f524f1
Compare
…eploymentDescriptorServlet.java Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial testing for #404