Faces 4.0: OutputScript/OutputStyleSheet Remove 'type' attribute if HTML5

[melloware]

For Faces 4.0 I would like to remove the type="text/javascript" from h:outputScript as its completely unnecessary in the DOM and there is only 1 kind of script

W3C Validator warnings:

I think we should also remove it from OmniFaces 4.0 and PrimeFaces 11.0 in the spots it used.

I can submit PR's for Mojarra and MyFaces if acceptable?

cc @OBreidenbach who reported this originally here: primefaces/primefaces#4135

[christophs78]

Good point!

[BalusC]

These are indeed optional in HTML5 but not in HTML4 (although the average webbrowser is lenient in this).

Also note that the same "issue" applies to <link|style type="text/css">. This is also optional in HTML5. So the same adjustments must be done for OutputStylesheet.

[melloware]

Yep but with the Death of IE. Should Faces 4.0 just be an HTML5+ supporting framework?

[BalusC]

There should be a way for the HTML renderers to detect the doctype currently used. Facelets is capable of this but this is nowhere specified in Faces (as far as I see/know).

Blindly removing it would break validity of (existing) HTML4 pages.

[melloware]

Ok detecting HTML5 doctype would be ideal. It would also be a nice addition to Faces

[BalusC]

Doctype processing is already specced in section 1.1.1.1 of appendix A of the spec, but it's only specced as part of Facelets config.

I'm currently having difficulty where to add it to the Faces API. Neither UIViewRoot#isHtml5Doctype() nor RenderKit#isHtml5Doctype() make sense.

[BalusC]

I've for the time being made it an implementation detail. If someone knows a valid and sensible API method for this then I'm all ears to add.

[melloware]

@tandraschko any thoughts on this one?

[BalusC]

After meditating a night on this one I think the closest candidate is UIViewRoot#getDoctype() and then leave it to the clients to sniff whether that's HTML5 or not. But then I'm in dubio whether it should return String or jakarta.faces.component.html.HtmlDoctype. If the latter, then we should ultimately need a new interface something like jakarta.faces.component.Doctype so that it can be declared as return type. This gives a proper degree of abstraction. A HTML5 doctype could then be identified by Doctype#getRootElement() returning html and the Doctype#getSystem() and Doctype#getPublic() both returning null.

[tandraschko]

UIViewRoot#getDoctype() sounds good

[melloware]

I like your plan @BalusC

[melloware]

MyFaces PR: apache/myfaces#198

Closing this ticket as its now implemented in MyFaces and Mojarra 4.0