Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mojarra #5160 and MYFACES-4491 #1891

Merged
merged 9 commits into from
Feb 17, 2024
Merged

Fixes mojarra #5160 and MYFACES-4491 #1891

merged 9 commits into from
Feb 17, 2024

Conversation

BalusC
Copy link
Member

@BalusC BalusC commented Feb 17, 2024

Replaces #1721 and fixes eclipse-ee4j/mojarra#5160

Changes as compared to #1721:

  1. renamed 'localized-composite' module to 'localizedComposite' conform naming conventions of all other tests
  2. renamed 'LocalizedComposite' in filenames to 'Issue5160' conform naming conventions of all other tests
  3. extract UIViewRoot locale from Accept-Language header instead of request.getLocale() because the latter apparently drops unsupported variants depending on currently used JDK, unintentionally causing the IT to fail
  4. added more tests covering more corner cases

cristof and others added 9 commits November 15, 2022 11:27
Adds tests to check issues mojarra #5160 and MYFACES-4491
1) renamed 'localized-composite' module to 'localizedComposite' conform
naming conventions of all other tests
2) renamed 'LocalizedComposite' in filenames to 'Issue5160' conform
naming conventions of all other tests
3) extract UIViewRoot locale from Accept-Language header instead of
request.getLocale() because the latter apparently drops unsupported
variants depending on currently used JDK
4) added more tests covering more corner cases
@arjantijms arjantijms added the TCK Any issue having to do with the TCK not the API of SPEC text label Feb 17, 2024
@arjantijms arjantijms added this to the 4.1.0-TCK milestone Feb 17, 2024
@arjantijms arjantijms merged commit a511dcd into 4.1 Feb 17, 2024
2 checks passed
@arjantijms arjantijms deleted the 1721 branch February 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TCK Any issue having to do with the TCK not the API of SPEC text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants