Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier to DriversSeat in TCK #15

Closed
wants to merge 1 commit into from

Conversation

Cousjava
Copy link

This qualifier is required as part of the test configuration, putting it here means it is part of the codebase and not from how the implementation configures the TCK runner.

@Ladicek
Copy link

Ladicek commented Mar 24, 2021

I think the TCK instructions are pretty clear in that this is supposed to be a configuration thing, and hence not part of the codebase. Similarly, you could also add @Named("spare") to the SpareTire class.

Now, I have no idea why it's been designed like that, but I have to assume that it was a conscious choice. At least, I'd expect the instructions in the README (and in the Tck class) to be updated in this PR as well.

@manovotn
Copy link

What's the motivation for this change?
Like Ladislav said, it is not the sole occurrence and I'd also like to believe that the choice was conscious, Besides, it might be breaking for whoever is running the TCKs,

@Cousjava
Copy link
Author

This change allows HK2 to pass, and it does not prevent Weld from passing (which currently does)

@Ladicek
Copy link

Ladicek commented Mar 24, 2021

I'd also like to highlight that forking AtInject into Jakarta doesn't mean we can change it willy nilly. At least some of the well-known previous implementors of AtInject are well aware that this exists and are considering to support it:

So, I do think we should keep these projects in mind.

@manovotn
Copy link

and it does not prevent Weld from passing (which currently does)

Did you try? I didn't, so I can't guarantee it ;-)

So, I do think we should keep these projects in mind.

+1, I'd say we don't change it. What's blocking HK2 from passing it in this form of other implementations can pass it?

@Cousjava Cousjava closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants