Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.1 release (implementation) #286

Merged
merged 2 commits into from
Apr 23, 2021
Merged

2.0.1 release (implementation) #286

merged 2 commits into from
Apr 23, 2021

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Apr 23, 2021

No description provided.

@lukasj lukasj changed the title 2.0.1 release 2.0.1 release (implementation) Apr 23, 2021
@keilw
Copy link
Member

keilw commented Apr 23, 2021

Does this correspond to jakartaee/specifications#343?

m0mus
m0mus approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj
Copy link
Contributor Author

lukasj commented Apr 23, 2021

@keilw no, this is implementation only

@keilw
Copy link
Member

keilw commented Apr 23, 2021

I know but is it the matching implementation, judging by the number it should?

@keilw
Copy link
Member

keilw commented Apr 23, 2021

I guess every committer can merge it, but as @m0mus approved, will you merge it @lukasj, or should I?

@lukasj lukasj merged commit fe26424 into master Apr 23, 2021
@lukasj lukasj deleted the 2.0.1 branch April 23, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0mus m0mus m0mus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasj @keilw @m0mus @jsonp-bot