Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude CDI_SE tests when running JSON-B TCK #1062

Closed

Conversation

scottmarlow
Copy link
Contributor

Signed-off-by: Scott Marlow smarlow@redhat.com

Workaround GlassFish 7 Web Profile not support CDI_SE tests

https://ci.eclipse.org/jakartaee-tck/job/10/job/jakarta-jsonb-tck-glassfish-run/lastCompletedBuild/testReport shows zero failures running JSON-B TCK with GlassFish 7 nightly build web profile.

Fixes Issue

jakartaee/jsonb-api#326

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

I mentioned this change on jakartaee/jsonb-api#326, lets see if the JSON-B team accepts this change as a valid workaround before merging.

@m0mus
Copy link
Contributor

m0mus commented Jun 10, 2022

JSONB TCK has two budles: the standalone bundle using JUnit and the platform bundle using JavaTest. The standalone bundle is designed for TCK testing a JSONB implementation, the platform bundle is designed to test a platform implementation. The reuirement is that JSONB implementation used in the platform is certified (passed the JUnit bundle).

What you are trying to do here is to extract JSONB implementation out of the platform and run JUnit bundle on it using the platform class/module path. It's not the way how JSONB TCKs are designed.

If Yasson is used (which is JSONB compliant) you don't need to run JUnit bundle at all. Run only the platform bundle. If other implementation is used, it must be JSONB certified first. It means that implementation authors should run JUnit bundle on it. It should not use any all server class/module path though. It also should provide all dependencies required by JUnit bundle including CDI SE.

@scottmarlow
Copy link
Contributor Author

I'm closing this as the TCK challenge was not accepted.

@scottmarlow scottmarlow deleted the jsonb_exclude_cdi_se branch December 12, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants