Updates for WebSocket 2.0 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
|
Hi Mark - I am making more signature file changes in #169. I will sync up my changes with respect to this this PR and other PRs with signature test changes . Thanks. |
alwin-joseph
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key changes are in the first commit.
The second fixes a build error.
The third and fourth are changes to the shared TCK infrastructure for Java 11 support.
I replaced the jakarta.websocket-api.jar and jakarta.servlet-api locally in glassfish with the M1 builds from Maven central to build this.
I ran the resulting TCK bundle against Apache Tomcat 10 implementation. The TCK passes when using both Java 8 and Java 11 with the exception of 2 tests which test behaviour which is ambiguously defined in the WebSocket spec.
The signature tests failed with Java 11 unless I replaced lib/sigtest.jar with the latest snapshot build
The error message in the logs was Unknown option -xjimage.
I'll be surprised if this PR is perfect first time around. Happy to adjust it as required after review.