Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start building with staged EE 10 SPEC APIs #761

Merged
merged 12 commits into from
Nov 9, 2021

Conversation

scottmarlow
Copy link
Contributor

@scottmarlow scottmarlow commented Oct 8, 2021

Signed-off-by: Scott Marlow smarlow@redhat.com

Adds the staging repo via added parent pom + updates to currently available staged SPEC API versions. Note that some SPEC APIs may be merged into Jakarta XML Web Services 4.0 (like Soap Attachments + Jakarta Web Services Metadata 3.0).

More changes are needed to deal with the technologies merged to https://jakarta.ee/specifications/xml-web-services/4.0 (with regard to building standalone TCKs).

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/2/testReport/ has test results. I would expect that the Persistence tests would of failed if #759 was merged in already.

@scottmarlow
Copy link
Contributor Author

Started a new test with just jpa standalone tck specified, will see if the results look more correct for https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/3 as the build#2 didn't seem to have jpa tests run.

@scottmarlow
Copy link
Contributor Author

My bad, test run # 2 is still running also. :-)

Copy link
Contributor

@gurunrao gurunrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove JAXB jars checked-in here - https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/lib, if we are using jars from maven central for the TCK build?

Copy link
Contributor

@gurunrao gurunrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar changes will be required for standalone tck build script - https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/docker/build_standalone-tcks.sh, to build from staged EE 10 SPEC API.

@scottmarlow
Copy link
Contributor Author

shall we remove JAXB jars checked-in here - https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/lib, if we are using jars from maven central for the TCK build?

Yes, thank you for pointing that out!

similar changes will be required for standalone tck build script - https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/docker/build_standalone-tcks.sh, to build from staged EE 10 SPEC API.

Good catch, I completely agree.

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/5 will build/run Platform TCK tests with JDK11

Signed-off-by: Scott Marlow <smarlow@redhat.com>
Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/7/ is running with some changes to https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/docker/build_standalone-tcks.sh, but we will see if the classpath is correct for compiling all of the various TCK sources.

Signed-off-by: Scott Marlow <smarlow@redhat.com>
Signed-off-by: Scott Marlow <smarlow@redhat.com>
…d CNFE compiling src/com/sun/ts/tests/ejb30/common/migration/threetwo/DescriptorThreeTestBean.java

Signed-off-by: Scott Marlow <smarlow@redhat.com>
…Context.java:23: error: cannot find symbol

 [ts.javac] import jakarta.xml.bind.Validator

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow scottmarlow added the 10.0 Issues related to the Jakarta EE 10 Platform TCK release label Nov 2, 2021
@scottmarlow
Copy link
Contributor Author

FYI, tracking issue is #756

…K classes to avoid CNFE compiling src/com/sun/ts/tests/ejb30/common/migration/threetwo/DescriptorThreeTestBean.java

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

Signed-off-by: Scott Marlow <smarlow@redhat.com>
…0-RC2

Signed-off-by: Scott Marlow <smarlow@redhat.com>
Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow
Copy link
Contributor Author

scottmarlow commented Nov 5, 2021

I'm doing more testing of the Standalone TCKs but I think they will all pass via https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/20 (verified that jaxrs passed yesterday which was the only one failing due to build failures that are now resolved).

Locally, I tried running the Platform TCK build from yesterday (https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/19/artifact/jakartaeetck-bundles/jakartaeetck-10.0.0.zip). I am locally running the jaxrs tests and they passed fine with WildFly (master branch):

[javatest.batch] ********************************************************************************
[javatest.batch] Finished Test:  PASSED........com/sun/ts/tests/jaxrs/ee/rs/formparam/sub/JAXRSSubClient.java#nonDefaultFormParamValueOfTest_from_standalone
[javatest.batch] ********************************************************************************
[javatest.batch] Number of tests completed:  1875 (1875 passed, 0 failed, 0 with errors)
[javatest.batch] Number of tests remaining:  990
.
.
.
[javatest.batch] Nov 5, 2021, 2:31:52 PM Finished executing all tests, wait for cleanup...
[javatest.batch] Nov 5, 2021, 2:31:52 PM Harness done with cleanup from test run.
[javatest.batch] Total time = 7,808s
[javatest.batch] Setup time = 0s
[javatest.batch] Cleanup time = 4s
[javatest.batch] Test results: passed: 2,803

While with https://download.eclipse.org/ee4j/glassfish/glassfish-6.1.0.zip on JDK11 testing, we fail with:

A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.StackOverflowError
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:315)

I'm guessing the java.lang.StackOverflowError is a configuration failure but not really sure.

Update: https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/add_staged_specapi/20/ passed all of the Standalone TCK tests.

@scottmarlow
Copy link
Contributor Author

Thanks for the review @gurunrao !

@scottmarlow scottmarlow merged commit 3b46ef0 into jakartaee:master Nov 9, 2021
@scottmarlow scottmarlow deleted the add_staged_specapi branch November 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.0 Issues related to the Jakarta EE 10 Platform TCK release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants