-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UUID entity. #793
Added UUID entity. #793
Conversation
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Keeping this as draft. This PR requires UUID JPA spec change to be merged and JPA Spec Assertion IDs to be updated. |
Nice. |
(heard that my code review comment isn't visible): |
@jgrassel I did not see your comment in the code. But adding clear is not a problem. I can do it with Spec Assertion IDs update. |
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
This PR contains JPA 3.1 spec assertions IDs update. |
JPA API 3.1.0-RC2 is in central. Test must be verified using this latest API. |
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testCreateUUIDType() seems to be missing the call to EntityManager.clear() which from previous comments, I expected to see added.
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Yes, I forgot it. Should be OK now.
|
Signed-off-by: Tomas Kraus tomas.kraus@oracle.com
name: Pull Request
about: Create a pull request for a Platform TCK change
title: JPA UUID Test
labels:
assignees: Tomas-Kraus
Fixes Issue
jakartaee/persistence#319
Related Issue(s)
jakartaee/persistence#151
jakartaee/persistence#152
Describe the change
Simple test to verify EM persist of an entity class with UUID.
Additional context
N/A
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow @lukasj