Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#937 Remove use of Applet API #938

Closed
wants to merge 1 commit into from

Conversation

scottmarlow
Copy link
Contributor

@scottmarlow scottmarlow commented Apr 19, 2022

Signed-off-by: Scott Marlow smarlow@redhat.com

Fixes Issue
#937 in support of jakartaee/platform#298

Describe the change
Applet is deprecated as of Java SE 17 and was removed from the EE 10 Platform SPEC. This change is removing the tests that use the Applet APIs.

CC @markt-asf @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow

Signed-off-by: Scott Marlow <smarlow@redhat.com>
@scottmarlow scottmarlow requested a review from markt-asf April 19, 2022 21:50
@markt-asf
Copy link
Contributor

Given the removal of support for NPAPI by browsers, we probably need to look at deprecating and removing <jsp:plugin> and associated structures. I could get the work done for that fairly quickly (in the next 24-28 hours) but is it practical to get that done for Jakarta EE 10?

Given the specs will still support <jsp:plugin> where use of applet is valid, this change seems like the simplest way forward for the TCK.

@starksm64
Copy link
Contributor

I would say that is the correct thing to do. Remove it from the spec and update the spec documents in the PR.
jakartaee/specifications#435

@markt-asf
Copy link
Contributor

Removal without prior deprecation would be unusual. I'd want to ensure there was wide support for that. It would also require moving to 4.0.0 which triggers a bunch of other processes. I'm not sure there is time to do this at this point.

Deprecation and a change to make the <jsp:plugin> a NO-OP could be done in the next 24 hours or so - including updating the TCK tests to ensure that they were NO-OPs (rather than removing the tests).

@starksm64
Copy link
Contributor

Applet support was deprecated previously, and has been removed from the platform specs. Making things a NO-OP would be a fine compromise.

@scottmarlow
Copy link
Contributor Author

Deprecation and a change to make the <jsp:plugin> a NO-OP could be done in the next 24 hours or so - including updating the TCK tests to ensure that they were NO-OPs (rather than removing the tests).

So the TCK tests would be updated to fail if the jsp:plugin is not ignored, that sounds good.

@markt-asf
Copy link
Contributor

PR for changes to Jakarta Pages: jakartaee/pages#228
Feedback welcome (on that PR please).

@markt-asf markt-asf mentioned this pull request Apr 21, 2022
@markt-asf
Copy link
Contributor

See #940 for my proposed alternative approach

@scottmarlow
Copy link
Contributor Author

This pr is replaced by #940

@scottmarlow scottmarlow deleted the applet branch December 12, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants