Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative ordering of web fragments #365

Closed
Thihup opened this issue Sep 24, 2020 · 3 comments
Closed

Relative ordering of web fragments #365

Thihup opened this issue Sep 24, 2020 · 3 comments

Comments

@Thihup
Copy link
Contributor

Thihup commented Sep 24, 2020

The spec says that valid ordering of the may be one of:

B, E, F, <no id>, C, D
B, E, F, <no id>, D, C
E, B, F, <no id>, C, D
E, B, F, <no id>, D, C
E, B, F, D, <no id>, C
E, B, F, D, <no id>, D

However, the last one repeats the "D" fragment,
Is this really valid or this should be E, B, F, C, <no id>, D?

@markt-asf
Copy link
Contributor

I don't think that is quite right as <no id> has to be before C. I think it should be:

B, E, F, <no id>, C, D
B, E, F, <no id>, D, C
E, B, F, <no id>, C, D
E, B, F, <no id>, D, C
E, B, F, D, <no id>, C
B, E, F, D, <no id>, C

I'd be tempted to reorder the list as well but for clarity I think I'll just correct the last line.
I'll provide a PR.

markt-asf added a commit to markt-asf/servlet-api that referenced this issue Oct 1, 2020
Signed-off-by: Mark Thomas <markt@apache.org>
@gregw
Copy link
Contributor

gregw commented Oct 16, 2020

@janbartel ?

@janbartel
Copy link
Contributor

@gregw I think @markt-asf is right and the last line is wrong: the last element must be C because <no id> must always be before C, and B E F can be in the order he shows.

It seems a little odd that that D could be interposed between <no id> and C but technically that maintains the relationship of <no id> before C so the spec is satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants