-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Service Release template per experiments with JAF and Mail #345
Conversation
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Deploy preview for jakartaee-specifications ready! Built with commit 651e398 https://deploy-preview-345--jakartaee-specifications.netlify.app |
there is one more thing in the XML binding spec and that is updating the spec document (see #340 (comment)). The question here is the form of the document revision - would probably make sense to capture the pattern to use there in one of the list items
I think it should be enough to put templates into |
Yes, I'll do that as soon as we are good with the updates. |
I think the versioning of spec documents is something we need to bring up in the spec committee. We should consider treating the document the same way as the other artifacts. Something like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we allow teams to release the API-jar as well if the JavaDoc is updated? It's part of the same source and CI jobs and is staged along with the JavaDoc It feels like extra work to figure out how to only release a couple of the staged artifacts to Maven Central.
I recall having a conversation with Bill on this topic long time ago and to make it short - now I've found: https://eclipse-ee4j.github.io/jakartaee-platform/Versioning:
|
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Updated the "Note" to indicate that API can have a third digit service release for the Javadoc. |
The EMO has also created the following Issue for the EFSP to possibly define an Errata update separate from the Service Release: EclipseFdn/EFSP#32 Maybe something like this would help with potential updates to the Specification itself? |
These additional discussions about a potential "service release" for the Specification are all good, but they go beyond the current definition of a Service Release. So, can we possibly just get the approvals on this template update in place so that the other Service Release issues can make progress? Thanks. |
Agree! Just approved |
Thanks, @ivargrimstad! Going ahead with the merge since we have several service releases queued up... |
That issue is trying to define errata as a "living document" external to the specification document, so it is not going to help us to fix #318 in specification documents where we basically need to provide new revision of the document (another case - consider CVE in the spec document itself, which is unlikely but it's just HTML/PDF after all, how are we going to deal with that?) |
Signed-off-by: Kevin Sutter kwsutter@gmail.com
Updating the Service Release template per the discussions with Lukas on JAF and Mail. I think I caught everything, but take a look. If we get this good, then we can move onto the other templates.
Also, is there a way to select which PR template to use when creating a PR (similar to selecting a template when creating an Issue)? We should do that.