Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Release template per experiments with JAF and Mail #345

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

kwsutter
Copy link
Contributor

Signed-off-by: Kevin Sutter kwsutter@gmail.com

Updating the Service Release template per the discussions with Lukas on JAF and Mail. I think I caught everything, but take a look. If we get this good, then we can move onto the other templates.

Also, is there a way to select which PR template to use when creating a PR (similar to selecting a template when creating an Issue)? We should do that.

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter kwsutter requested a review from ivargrimstad March 31, 2021 21:42
@netlify
Copy link

netlify bot commented Mar 31, 2021

Deploy preview for jakartaee-specifications ready!

Built with commit 651e398

https://deploy-preview-345--jakartaee-specifications.netlify.app

@kwsutter kwsutter mentioned this pull request Mar 31, 2021
18 tasks
@lukasj
Copy link
Contributor

lukasj commented Mar 31, 2021

I think I caught everything

there is one more thing in the XML binding spec and that is updating the spec document (see #340 (comment)). The question here is the form of the document revision - would probably make sense to capture the pattern to use there in one of the list items

Also, is there a way to select which PR template to use when creating a PR (similar to selecting a template when creating an Issue)? We should do that.

I think it should be enough to put templates into <root>/.github/ISSUE_TEMPLATE/ folder (but check docs)

@ivargrimstad
Copy link
Member

I think it should be enough to put templates into <root>/.github/ISSUE_TEMPLATE/ folder (but check docs)

Yes, I'll do that as soon as we are good with the updates.

@ivargrimstad
Copy link
Member

I think I caught everything

there is one more thing in the XML binding spec and that is updating the spec document (see #340 (comment)). The question here is the form of the document revision - would probably make sense to capture the pattern to use there in one of the list items

I think the versioning of spec documents is something we need to bring up in the spec committee. We should consider treating the document the same way as the other artifacts. Something like:

  • The specification itself has a two-digit version number (X.Y)

  • All the artifacts have a three-digit version number (x.y.z)

  • Jakarta Wombat X.Y

    • jakarta-wombat-spec-x.y.x.pdf
    • jakarta-wombat-spec-x.y.z.html
    • jakarta-wombat:jakarta-wombat-api:z.y.z
    • jakarta-wombat:jakarta-wombat-javadoc:x.y.z
    • jakarta-wombat-tck-x.y.z.zip

Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow teams to release the API-jar as well if the JavaDoc is updated? It's part of the same source and CI jobs and is staged along with the JavaDoc It feels like extra work to figure out how to only release a couple of the staged artifacts to Maven Central.

@lukasj
Copy link
Contributor

lukasj commented Apr 1, 2021

I think the versioning of spec documents is something we need to bring up in the spec committee.

I recall having a conversation with Bill on this topic long time ago and to make it short - now I've found: https://eclipse-ee4j.github.io/jakartaee-platform/Versioning:

For a spec of version X.Y, the spec document will be version “X.Y” for the initial release or “X.Y Rev L”, where “L” is a letter nominally starting with “a” and incrementing as more errata are approved via the Jakarta EE Specification Process.

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter
Copy link
Contributor Author

kwsutter commented Apr 1, 2021

Shouldn't we allow teams to release the API-jar as well if the JavaDoc is updated? It's part of the same source and CI jobs and is staged along with the JavaDoc It feels like extra work to figure out how to only release a couple of the staged artifacts to Maven Central.

Updated the "Note" to indicate that API can have a third digit service release for the Javadoc.

@kwsutter
Copy link
Contributor Author

kwsutter commented Apr 1, 2021

I think the versioning of spec documents is something we need to bring up in the spec committee.

I recall having a conversation with Bill on this topic long time ago and to make it short - now I've found: https://eclipse-ee4j.github.io/jakartaee-platform/Versioning:

For a spec of version X.Y, the spec document will be version “X.Y” for the initial release or “X.Y Rev L”, where “L” is a letter nominally starting with “a” and incrementing as more errata are approved via the Jakarta EE Specification Process.

The EMO has also created the following Issue for the EFSP to possibly define an Errata update separate from the Service Release: EclipseFdn/EFSP#32 Maybe something like this would help with potential updates to the Specification itself?

@kwsutter
Copy link
Contributor Author

kwsutter commented Apr 1, 2021

These additional discussions about a potential "service release" for the Specification are all good, but they go beyond the current definition of a Service Release. So, can we possibly just get the approvals on this template update in place so that the other Service Release issues can make progress? Thanks.

@ivargrimstad ivargrimstad self-requested a review April 1, 2021 14:47
@ivargrimstad
Copy link
Member

These additional discussions about a potential "service release" for the Specification are all good, but they go beyond the current definition of a Service Release. So, can we possibly just get the approvals on this template update in place so that the other Service Release issues can make progress? Thanks.

Agree! Just approved

@kwsutter
Copy link
Contributor Author

kwsutter commented Apr 1, 2021

Thanks, @ivargrimstad! Going ahead with the merge since we have several service releases queued up...

@kwsutter kwsutter merged commit 87a4406 into jakartaee:master Apr 1, 2021
@kwsutter kwsutter deleted the sr-template-update branch April 1, 2021 15:58
@lukasj
Copy link
Contributor

lukasj commented Apr 1, 2021

The EMO has also created the following Issue for the EFSP to possibly define an Errata update separate from the Service Release: EclipseFdn/EFSP#32 Maybe something like this would help with potential updates to the Specification itself?

That issue is trying to define errata as a "living document" external to the specification document, so it is not going to help us to fix #318 in specification documents where we basically need to provide new revision of the document (another case - consider CVE in the spec document itself, which is unlikely but it's just HTML/PDF after all, how are we going to deal with that?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants