Port TLDDoc Source Code #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnicolucci @arjantijms I skipped the deployment step so the TLDDoc jar shouldn't be published (but will be used locally when building jstl-api) Let me know if you have any concerns / questions here. |
volosied
force-pushed
the
195-tlddoc
branch
2 times, most recently
from
e4e95cc
to
7ea460e
Compare
pzygielo
reviewed
Jan 18, 2022
pnicolucci
reviewed
Jan 19, 2022
pnicolucci
reviewed
Jan 19, 2022
volosied
force-pushed
the
195-tlddoc
branch
4 times, most recently
from
52d9f57
to
2ca0ab3
Compare
volosied
force-pushed
the
195-tlddoc
branch
4 times, most recently
from
7d10c20
to
57f792b
Compare
Update source/target options Moves TLDDoc resources to resources folder Create TLDDoc module; set version to 2.0-SNAPSHOT Review Updates; Add comment about tlddoc deployment More Review Updates Update tlddoc groupid to org.glassfish.web update to tagsdoc Move source to tagsdoc fix artifactId error Update tagsdoc pom
pnicolucci
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #195
Approval was granted via QC 23881, so I'm checking the code in.
mvn clean installwhen run at root)I used the default pom.xml, with a few major modifications:
Source: https://repo1.maven.org/maven2/taglibrarydoc/tlddoc/1.3