Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TLD docs to profile #211

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Move TLD docs to profile #211

merged 1 commit into from
Feb 7, 2022

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: Arjan Tijms arjan.tijms@gmail.com

Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms arjantijms added this to the 3.0.0 milestone Feb 5, 2022
Copy link
Contributor

@volosied volosied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the replacement I'd prefer to use #208, but I think adding the comment about tlddoc is fine for the Milestone releases (as we work on updating the tlddoc code in the meantime)

@volosied
Copy link
Contributor

volosied commented Feb 7, 2022

@pnicolucci What's your opinion?

@arjantijms arjantijms merged commit 72fb7d5 into master Feb 7, 2022
@arjantijms arjantijms deleted the tlddocs branch February 7, 2022 17:11
@arjantijms
Copy link
Contributor Author

For the replacement I'd prefer to use #208,

Yes that would definitely be better going forward. But indeed, this is just for a milestone release. It's good to have these out anyway, but in this case depending on building a snapshot of this project during the GF build proved to be quite unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants