Use the same lock for all methods accessing Validation.GetValidationProviderListAction#providersPerClassloader #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roviderListAction#providersPerClassloader `clearCache` was a static method and thus was synchronized on the class, while `getCachedValidationProviders`/`cacheValidationProviders` are instance methods and thus are synchronized on a particular instance. This means it was theoretically possible for `clearCache` and `getCachedValidationProviders`/`cacheValidationProviders` to access the providersPerClassloader map concurrently, which is a problem because WeakHashMap is not thread-safe. This may fix jakartaee#180, though it's hard to say without a proper thread dump showing what the cause of the deadlock was exactly. In any case, this will prevent synchronization issues for integrators that call Validation#clearDefaultValidationProviderResolverCache concurrently to Validation.DefaultValidationProviderResolver#getValidationProviders.
|
@gsmet I can't merge this myself :) Could you please review it? |
gsmet
approved these changes
Aug 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearCachewas a static method and thus was synchronized on the class,while
getCachedValidationProviders/cacheValidationProvidersare instance methods and thus are synchronized on a particular instance.
This means it was theoretically possible for
clearCacheandgetCachedValidationProviders/cacheValidationProvidersto access theprovidersPerClassloader map concurrently,
which is a problem because WeakHashMap is not thread-safe.
This may fix #180, though it's hard to say without a proper thread dump
showing what the cause of the deadlock was exactly.
In any case, this will prevent synchronization issues for integrators
that call Validation#clearDefaultValidationProviderResolverCache
concurrently to Validation.DefaultValidationProviderResolver#getValidationProviders.
Fixes #180 (possibly?)