Fix all at-internal comments, which need to be attached to a declaration

jakebailey · Sep 13, 2022 · 9702a2e · 9702a2e
1 parent bb294f7
commit 9702a2e
Show file tree

Hide file tree

Showing 52 changed files with 938 additions and 424 deletions.
diff --git a/src/api-extractor-base.json b/src/api-extractor-base.json
@@ -379,6 +379,23 @@
         "default": {
           "logLevel": "warning"
           // "addToApiReportFile": false
+        },
+
+        "ae-internal-missing-underscore": {
+          "logLevel": "none",
+          "addToApiReportFile": false
+        },
+
+        // TODO(jakebailey): should we explicitly mark things as public?
+        "ae-missing-release-tag": {
+          "logLevel": "none",
+          "addToApiReportFile": false
+        },
+
+        // TODO(jakebailey): Fix these?
+        "ae-unresolved-link": {
+          "logLevel": "none",
+          "addToApiReportFile": false
         }
 
         // "ae-extra-release-tag": {
@@ -398,8 +415,8 @@
        */
       "tsdocMessageReporting": {
         "default": {
-          "logLevel": "warning"
-          // "addToApiReportFile": false
+          "logLevel": "none",
+          "addToApiReportFile": false
         }
 
         // "tsdoc-link-tag-unescaped-text": {

diff --git a/src/compiler/builder.ts b/src/compiler/builder.ts
@@ -92,9 +92,10 @@ export const enum BuilderFileEmit {
     Full
 }
 
-/** @internal */
 /**
  * State to store the changed files, affected files and cache semantic diagnostics
+ *
+ * @internal
  */
 // TODO: GH#18217 Properties of this interface are frequently asserted to be defined.
 export interface BuilderProgramState extends BuilderState, ReusableBuilderProgramState {
@@ -803,15 +804,17 @@ export type ProgramBuildInfoBuilderStateFileInfo = Omit<BuilderState.FileInfo, "
      */
     signature: string | false | undefined;
 };
-/** @internal */
 /**
  * [fileId, signature] if different from file's signature
  * fileId if file wasnt emitted
+ *
+ * @internal
  */
 export type ProgramBuildInfoEmitSignature = ProgramBuildInfoFileId | [fileId: ProgramBuildInfoFileId, signature: string];
-/** @internal */
 /**
  * ProgramBuildInfoFileInfo is string if FileInfo.version === FileInfo.signature && !FileInfo.affectsGlobalScope otherwise encoded FileInfo
+ *
+ * @internal
  */
 export type ProgramBuildInfoFileInfo = string | ProgramBuildInfoBuilderStateFileInfo;
 /** @internal */