stream: callback should be called when pendingcb is 0

Fixes: nodejs#46170
jakecastelli · Jun 13, 2024 · 02c7662 · 02c7662
1 parent 5a19a9b
commit 02c7662
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/internal/streams/end-of-stream.js b/lib/internal/streams/end-of-stream.js
@@ -215,7 +215,9 @@ function eos(stream, options, callback) {
     (!willEmitClose || isReadable(stream)) &&
     (writableFinished || isWritable(stream) === false)
   ) {
-    process.nextTick(onclosed);
+    if (wState && wState.pendingcb === 0) {
+      process.nextTick(onclosed);
+    }
   } else if (
     !writable &&
     (!willEmitClose || isWritable(stream)) &&

diff --git a/test/parallel/test-stream-finished.js b/test/parallel/test-stream-finished.js
@@ -679,5 +679,6 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
 
   finished(stream, { readable: false }, common.mustCall((err) => {
     assert(!err);
+    assert.strictEqual(stream._writableState.pendingcb, 0)
   }));
 }