Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure calculations for weighting is true to the original algorithm #5

Closed
jakewilliami opened this issue Aug 26, 2020 · 2 comments
Closed

Ensure calculations for weighting is true to the original algorithm #5

jakewilliami opened this issue Aug 26, 2020 · 2 comments
Labels
make correct Make something more correct to what it should be doing

Comments

@jakewilliami
Copy link
Owner

print(weights) at the line before this line will print the array

[0.00020585 0.00020585 0.00020585 ... 0.00020585 0.00020585 0.00020585]

And print(weights) after said line will print arrays

[0.00020585 0.00020585 0.00020585 ... 0.00020585 0.00020585 0.00020585]
[0.00020585 0.00020585 0.00020585 ... 0.00020585 0.00020585 0.00020585]
[0.00013831 0.00013831 0.00013831 ... 0.00013831 0.00030636 0.00030636]

I need to replicate this in Julia.
@jakewilliami jakewilliami added the make correct Make something more correct to what it should be doing label Aug 26, 2020
@jakewilliami
Copy link
Owner Author

Distinctly not fixed. I thought this was fixed because I rectified the featureIndices size, but this is still incorrect. May relate to the result of #11.

@jakewilliami jakewilliami reopened this Aug 26, 2020
jakewilliami added a commit that referenced this issue Aug 27, 2020
@jakewilliami
Rectified an issue which remained from a mistaken commit (ac61810). F…
6b35f6d 
…ixes weighting error (closing #5) and accuracy (closes #11) [had to fix votes calculations due to accidental  in defining , and tentatively but incorrectly implemented zerosarray---kept the function just in case].  Woohoo!  That's the algorithm.
@jakewilliami
Copy link
Owner Author

Closed by 6b35f6d.

jakewilliami added a commit that referenced this issue Sep 1, 2020
@jakewilliami
I have been silly and have not always translated to , but rather just…
140d888 
… ; this commit fixes issues regarding weight calculations related to that (and related to the construction of featureIndices by *not* compressing the size of the image; closes #5)
jakewilliami added a commit that referenced this issue Sep 1, 2020
@jakewilliami
Rectified an issue which remained from a mistaken commit (ac61810). F…
c4aa4e6 
…ixes weighting error (closing #5) and accuracy (closes #11) [had to fix votes calculations due to accidental  in defining , and tentatively but incorrectly implemented zerosarray---kept the function just in case].  Woohoo!  That's the algorithm.
jakewilliami added a commit that referenced this issue Sep 1, 2020
@jakewilliami
I have been silly and have not always translated to , but rather just…
ab7ced1 
… ; this commit fixes issues regarding weight calculations related to that (and related to the construction of featureIndices by *not* compressing the size of the image; closes #5)
jakewilliami added a commit that referenced this issue Sep 1, 2020
@jakewilliami
Rectified an issue which remained from a mistaken commit (ac61810). F…
65c9bd6 
…ixes weighting error (closing #5) and accuracy (closes #11) [had to fix votes calculations due to accidental  in defining , and tentatively but incorrectly implemented zerosarray---kept the function just in case].  Woohoo!  That's the algorithm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
make correct Make something more correct to what it should be doing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakewilliami