Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation #57

Merged
merged 8 commits into from
Nov 4, 2021
Merged

Optimisation #57

merged 8 commits into from
Nov 4, 2021

Conversation

jakewilliami
Copy link
Owner

Completed most optimisation changes:

  • Switched from print statements to @info and added ability to turn off the progress bar using the new(ish) ProgressMeter keyword argument enabled
    • As such, removed test-specific dependencies, as they were no longer needed
  • Optimised parts of the AdaBoost algorithm
  • Used generics where possible
    • TODO: ensure everything is type stable
  • Ensure functions which require an integral image as input use IntegralArray types, not just array types, as it does not make theoretical sense to accept any other type here
  • Slight bug fix in calculation of weights (indexing error)
  • Added example script using FFHQ dataset for faces and THINGS dataset for non-faces, with around 70–80% accuracy for both (from a subset of 2000 training images and 2000 testing images per category)
  • Added benchmarking script (required to check that optimisations were indeed optimising)
  • Convention fixes in code (Blue Code Style and Julia Lang conventions)
  • Added @inbounds in some places where suitable
    • TODO: Add more @inbounds and add @views where possible

@jakewilliami jakewilliami merged commit 2a1b1e3 into master Nov 4, 2021
@jakewilliami jakewilliami deleted the optimisation branch November 4, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant