-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve faceness measure #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously incorrectly calculated. The results for this are looking much more promising now. The method of calculation is more in-line with what was originally proposed: > As for your question about adapting the Viola-Jones face detector to return a measure of face-likeness - I think one simple thing you could use is the number of features computed before terminating from the cascade. Face patches always make it to the end of the cascade, i.e. all Haar-like features are computed. Non-faces usually result in early termination from the cascade, and the earlier, the less face-like the patch is (roughly speaking). This certainly would not be a perfect measure, but I'm confident that there is a positive correlation between the total number of features computed in the cascade and the "face-likeness".
Setting these environment variables in the main module file ([`FaceDetection.jl`](src/FaceDetecton.jl)) doesn't do anything to the environment for some reason. Various functions in Adaboost will pull from the environment, defaulting to `"true"`. If you need to turn off warnings and logging in the training phase, you can set these to `"false"` in your scripts.
As `get_score` no longer returns `faceness` (error in calculation; see 3a17220), it does not make sense to calculate the faceness of an image using a single feature, so we have ensured this is not implemented. We have changed the tests accordingly. You should use the other method of `get_faceness`, which calculates the faceness given potentially many classifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description TODO