Plus characters not recognized in unordered lists

[leesoh]

First off, thanks for all the work you've put into this extension! I really like the approach; it does almost everything I need and nothing I don't!

I've noticed some unexpected behaviour with lists. Both GitHub Flavoured and CommonMark%20.&text=Use%20any%20of%20*%20%2C%20%2B%20or,consistently%20use%20the%20same%20character.) specify that -, *, and + are all valid characters for a list, but + doesn't appear to be detected as such when using the <C-Space> shortcut to work with To Dos.

Reproduction Steps

Option 1

1. Open a new markdown file.
2. Enter + To do item on a new line.
3. In Normal mode, press <C-Space>. Note that a to do item does not get created.

Option 2

1. Open a new markdown file.
2. Enter - [ ] To do item on a new line.
3. Press enter to create a new to do item.
4. Press <C-t> to indent, and update the nested list item from - to +.
5. In Normal mode, press <C-Space>. Note that the to do item does not progress, nor does the parent task.

Hopefully this is sufficient to reproduce (and hopefully I haven't missed something obvious in the documentation!). If not, please let me know and I'd be happy to provide additional information.

[jakewvincent]

Hi @leesoh, this is right--currently, only - and * are supported as unordered list markers. However, it'll be very easy to include +. I'll add this in tomorrow.

[leesoh]

Thank you!!

[jakewvincent]

Just added this! Let me know if you have any issues with it--I think I got all the necessary regex patterns updated.

[leesoh]

Hi Jake! I just updated my the plugin and tried this out. It seems that <C-space> on a bulleted list adds [ ], but so does every additional press of <C-space>, rather than toggling list completion.

[jakewvincent]

I forgot a couple of patterns. Can you pull the latest update and try this again?

[jakewvincent]

If you're interested in seeing the patterns I needed to update for this fix, by the way, you can check out the diffs in these commits:

6f56ec8
8a88e70

[leesoh]

Thank you! I'll take a look at those commits. In the meantime, the <C-space> is now working for * and + bullets, but I'm seeing the same behaviour on -. Also, the parent bullets don't appear to be updated when child items are toggled.

…

On Fri, Jan 6, 2023 at 10:03 AM Jake Vincent ***@***.***> wrote: If you're interested in seeing the patterns I needed to update for this fix, by the way, you can check out the diffs in these commits: 6f56ec8 <6f56ec8> 8a88e70 <8a88e70> — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXV3Q5AYNR35AQ4G7EXLTWRBF7RANCNFSM6AAAAAATPJQ2JM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jakewvincent]

Thanks for testing it! I'll try to fix the remaining issues today.

[jakewvincent]

All right, I've made some additional tweaks and everything appears to be working as expected on my end. Can you confirm?

[leesoh]

Looks good to me!! Thank you so much for doing this :)

…

On Fri, Jan 6, 2023 at 10:53 AM Jake Vincent ***@***.***> wrote: All right, I've made some additional tweaks and everything appears to be working as expected on my end. Can you confirm? — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXV3UCTBZXSIAX5JK25YTWRBLYVANCNFSM6AAAAAATPJQ2JM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jakewvincent]

Great! No problem.