-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plus characters not recognized in unordered lists #112
Comments
Hi @leesoh, this is right--currently, only |
Thank you!! |
Just added this! Let me know if you have any issues with it--I think I got all the necessary regex patterns updated. |
Hi Jake! I just updated my the plugin and tried this out. It seems that |
I forgot a couple of patterns. Can you pull the latest update and try this again? |
Thank you! I'll take a look at those commits. In the meantime, the
<C-space> is now working for * and + bullets, but I'm seeing the same
behaviour on -. Also, the parent bullets don't appear to be updated when
child items are toggled.
…On Fri, Jan 6, 2023 at 10:03 AM Jake Vincent ***@***.***> wrote:
If you're interested in seeing the patterns I needed to update for this
fix, by the way, you can check out the diffs in these commits:
6f56ec8
<6f56ec8>
8a88e70
<8a88e70>
—
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXV3Q5AYNR35AQ4G7EXLTWRBF7RANCNFSM6AAAAAATPJQ2JM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for testing it! I'll try to fix the remaining issues today. |
All right, I've made some additional tweaks and everything appears to be working as expected on my end. Can you confirm? |
Looks good to me!! Thank you so much for doing this :)
…On Fri, Jan 6, 2023 at 10:53 AM Jake Vincent ***@***.***> wrote:
All right, I've made some additional tweaks and everything appears to be
working as expected on my end. Can you confirm?
—
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXV3UCTBZXSIAX5JK25YTWRBLYVANCNFSM6AAAAAATPJQ2JM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Great! No problem. |
First off, thanks for all the work you've put into this extension! I really like the approach; it does almost everything I need and nothing I don't!
I've noticed some unexpected behaviour with lists. Both GitHub Flavoured and CommonMark%20.&text=Use%20any%20of%20*%20%2C%20%2B%20or,consistently%20use%20the%20same%20character.) specify that
-
,*
, and+
are all valid characters for a list, but+
doesn't appear to be detected as such when using the<C-Space>
shortcut to work with To Dos.Reproduction Steps
Option 1
+ To do item
on a new line.<C-Space>
. Note that a to do item does not get created.Option 2
- [ ] To do item
on a new line.<C-t
> to indent, and update the nested list item from-
to+
.<C-Space>
. Note that the to do item does not progress, nor does the parent task.Hopefully this is sufficient to reproduce (and hopefully I haven't missed something obvious in the documentation!). If not, please let me know and I'd be happy to provide additional information.
The text was updated successfully, but these errors were encountered: