Add CLI #1
Merged
Add CLI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sick man, thanks for this! Going to add a couple comments. |
| himawari({ | ||
| zoom: argv.zoom || 1, | ||
| outfile: outfile, | ||
| date: argv.date || 'latest', |
There was a problem hiding this comment.
Shouldn't we assume the defaults have been loaded already? argv.date as well as argv.zoom ?
There was a problem hiding this comment.
good point, I'll remove || 1 & || 'latest'
|
Thanks @ngoldman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome module! I added a command line interface so you can do something like:
$ npm i -g himawari $ himawari --help Usage: himawari [options] --zoom, -z The zoom level of the image. Can be 1-4. (default: 1) --date, -d The time of the picture desired. If you want to get the latest image, use "latest". (default: "latest") --outfile, -o The location to save the resulting image. (default: "himawari-{date}.jpg" in current directory) --help, -h show help $ himawari -o ~/Desktop/earth-latest.jpg Creating earth-latest.jpg in /Users/ng/Desktop ... Saved 1/16 Saved 2/16 Saved 3/16 Saved 4/16 Saved 5/16 Saved 6/16 Saved 7/16 Saved 8/16 Saved 9/16 Saved 10/16 Saved 11/16 Saved 12/16 Saved 13/16 Saved 14/16 Saved 15/16 Saved 16/16 Complete!Please let me know if you're open to adding this to your module and if you want me to make any changes to the interface.
If you prefer I can also publish this as a separate module (e.g.
himawari-cli).