Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RV-8263-C8 driver #283

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Add RV-8263-C8 driver #283

merged 6 commits into from
Jul 17, 2024

Conversation

Kampi
Copy link
Collaborator

@Kampi Kampi commented May 27, 2024

  • Add RV-8263-C8 driver
  • Some smaller fixes

Closes #284
Closes #267
Closes #285
Closes #281
Closes #311

@Kampi Kampi added the enhancement New feature or request label May 27, 2024
@Kampi Kampi self-assigned this May 27, 2024
@Kampi Kampi requested a review from jakkra May 27, 2024 08:37
@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 9 times, most recently from 4f9428a to ea3e59a Compare May 27, 2024 14:17
@jakkra
Copy link
Owner

jakkra commented May 27, 2024

Skimmed through, see nothing that looks out of the ordinary. Let's see if it works later :)

@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 2 times, most recently from 54b2a78 to b469e66 Compare May 27, 2024 20:12
- Rename display driver to match it with the vendor_type scheme of the other drivers
- Remove Funkytown song from Buzzer driver
- Disable selecting of the step counter and battery arc in digital watchface
- Reorganize Kconfig and move the application configuration into the "Applications" menu
- Add RV-8263-C8 driver
- Couple smaller changes
@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 4 times, most recently from 8cbe6e8 to 55f45b9 Compare May 29, 2024 13:55
- Add RV-8263-C8 driver
- Couple smaller changes
@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 2 times, most recently from 6ef6806 to d202acc Compare May 29, 2024 17:36
@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 2 times, most recently from fe9105a to 558ce6c Compare June 20, 2024 06:46
@Kampi Kampi marked this pull request as ready for review June 20, 2024 07:08
@Kampi
Copy link
Collaborator Author

Kampi commented Jun 20, 2024

@jakkra I dropped my driver and use my driver from Zephyr instead. The driver is functional on HW (tested with dev-board) and also tested via the Zephyr unit test for the RTC API.

@Kampi
Copy link
Collaborator Author

Kampi commented Jul 12, 2024

@jakkra have you tested it on rev 5? I did some smaller changes on the driver so I have to update the patch.

@jakkra
Copy link
Owner

jakkra commented Jul 12, 2024

@jakkra have you tested it on rev 5? I did some smaller changes on the driver so I have to update the patch.

Nope, I'll let you have the honor 😉

@Kampi Kampi force-pushed the Add-RV-8263-C8-Driver branch 4 times, most recently from f0cb379 to 9467849 Compare July 16, 2024 13:41
app/patches/rv8263_rtc.patch Outdated Show resolved Hide resolved
… Zephyr

- Move patches from "zephyr_patches" directory into "patches" directory
- Remove "zephyr_patches" directory
- Add RTC to firmware
@Kampi
Copy link
Collaborator Author

Kampi commented Jul 16, 2024

@jakkra let´s merge this branch. The RTC driver has been added, but no RTC in the code yet. So we can reduce the complexity and add the RTC later to the firmware without the other stuff.

@jakkra jakkra merged commit 5fd5a46 into jakkra:main Jul 17, 2024
12 of 13 checks passed
@Kampi Kampi deleted the Add-RV-8263-C8-Driver branch July 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
2 participants