fix change detection in hierarchy ui #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
hierarchy_ui
doesn't returntrue
when the selection is modified by clicking on a nested entity.This problem can be reproduced by running the
egui_dock
exmaple:Pbr Mesh (6v0)
entity on the leftResources
PointLight (7v0)
on the leftDoing so should update the inspector to display information about the point light but it doesn't because
hierarchy_ui
doesn't returntrue
in this case:bevy-inspector-egui/crates/bevy-inspector-egui/examples/integrations/egui_dock.rs
Lines 213 to 216 in 1b916a0