Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.14 #197

Merged
merged 8 commits into from
Jul 6, 2024
Merged

Conversation

kristoff3r
Copy link
Contributor

No description provided.

@kristoff3r kristoff3r marked this pull request as ready for review June 16, 2024 14:59
@kristoff3r
Copy link
Contributor Author

This seems to work, but it's missing color pickers for all the new color spaces introduced. Also I haven't ensured that the ranges for color grading is correct nor tested those, as I'm not at all familiar with the math or terminology.

@kristoff3r
Copy link
Contributor Author

I can't reproduce the test failures locally :/

@tychedelia
Copy link

but it's missing color pickers for all the new color spaces introduced

I think it's okay to just add color pickers for the Srgba and Hsva structs rather than for the entire color enum.

@Azorlogh
Copy link
Contributor

The Debug impl for Entity became more verbose in 0.14 which now leads to this result
image
I think we should change these two lines to use "{}" instead of "{:?}":

return format!("{} ({:?})", name.as_str(), entity);

return format!("{} ({:?})", name.as_str(), entity);

@tychedelia
Copy link

blocked on mvlabat/bevy_egui#284 (comment)

@tomara-x
Copy link

tomara-x commented Jul 5, 2024

bevy_egui 0.28 is out now

@jakobhellermann
Copy link
Owner

Thanks for the PR, I'll take a look and merge tomorrow

@kristoff3r
Copy link
Contributor Author

Hmm, bevy_egui bumped both the egui version and the bevy version in the same release, and egui-dropdown and transform-gizmo-egui still haven't updated.

@kristoff3r
Copy link
Contributor Author

I inlined egui-dropdown to test, it was very easy to update. I'm not sure if we should do a PR and ping the author or just keep it, it's a very small dependency.

@jakobhellermann
Copy link
Owner

Thanks a lot for the PR! Everything looks good to me

@jakobhellermann jakobhellermann merged commit b18706c into jakobhellermann:main Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants