Do not try to re-install same PhantomJS version

[igorsantos07]

I've noticed that, after the first install, the scripts try to install again the same PhantomJS binary every time we mess around with Composer. Would be better if it noticed there was no need to update anything, and skip that procedure.

[jakoch]

Yes, the file is downloaded to the cache and overwritten from the cache each time.
So, it's constantly overwriting on installation or update.
There is no version comparison in place (so it doesn't know if it's a new version or not).

• add "if file exists & same as in cache, skip copying"

[vesper8]

+1

[iainp999]

Another +1 here

[InputOutput]

yes please +1

[jakoch]

Ok, i've added a version comparison between the requested version and the already installed version.

The installation of PhantomJS is skipped (on a second run of the installer), when the installed version is lower or equal to the version you are trying to install.
Or in other words: only a newer version will be installed, if PhantomJS is already installed.

The changes are on the dev-master branch. (It's prepared as 2.1.1-p04 tag, but not tagged, yet.)

It would be nice, if you find the time to test this and provide some feedback.

Best, Jens

[InputOutput]

Sure I'll give it a run

[InputOutput]

Looking good!

vagrant@backend:~/kaartje2go.nl/app$ composer update

[blablabla]

PhantomInstaller\Installer::installPhantomJS

• PhantomJS v2.1.1 is already installed. Skipping the installation.

vagrant@backend:~/kaartje2go.nl/app$ composer install

[blablabla]

PhantomInstaller\Installer::installPhantomJS

• PhantomJS v2.1.1 is already installed. Skipping the installation.
  vagrant@backend:~/kaartje2go.nl/app$

[jakoch]

Thank you for the quick feedback!
Let's tag it...

The new version is 2.1.1-p04.