Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use static to access chmod constant #27

Merged
merged 1 commit into from
Feb 18, 2016
Merged

Conversation

adam187
Copy link
Contributor

@adam187 adam187 commented Feb 18, 2016

to allow override via extending class like so:

use PhantomInstaller\Installer as BaseInstaller;

class Installer extends BaseInstaller
{
    const PHANTOMJS_CHMODE = 0755;
}

to allow override via extending class
jakoch added a commit that referenced this pull request Feb 18, 2016
use static to access chmod constant
@jakoch jakoch merged commit 3d69585 into jakoch:master Feb 18, 2016
@jakoch
Copy link
Owner

jakoch commented Feb 18, 2016

Yes, that makes sense.. lets add it.

By the way: is 770 to open?

@adam187
Copy link
Contributor Author

adam187 commented Feb 18, 2016

@jakoch Thx :)

Actually it's to close in my case.

I have use case where user that is running nginx/php is deferent then user that runs cli scripts so i need 0755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants