Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git pull hangs #852

Open
lbroekhuizen opened this issue Oct 8, 2019 · 2 comments
Open

git pull hangs #852

lbroekhuizen opened this issue Oct 8, 2019 · 2 comments

Comments

@lbroekhuizen
Copy link

When there aremany new branches on the server which are not on the client, Git pull hangs during the communication with Bonobo. This happens when the response of upload-pack is larger than 4k.
The ouput (and input) buffer of a console app is maximum 4 k.
When the output buffer is full git stops processing the input buffer. Thereby the process hangs.

lbroekhuizen added a commit to lbroekhuizen/Bonobo-Git-Server that referenced this issue Oct 8, 2019
Solved by starting a thread to read the output stream of the console app.
@willdean
Copy link
Collaborator

Thanks for this - it it the same issue as #840 would solve?

@lbroekhuizen
Copy link
Author

Hi Will,

Yes this solves the same problem. I did not find the other issue while searching for the problem.
I thought about using async calls. But the two async solutions I saw were changing the whole to async, which was a bit much. Or looping like #840. But when looping you use the processor for 100%. So quite heavy for the server.
Spawning another thread was les work and less pressure on the processor. The read hangs when there is no data.

Regards,
Leon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants