-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hotfix for initial WindowsAuthentication use. #763
base: master
Are you sure you want to change the base?
Conversation
Thanks for this, but I feel like something more fundamental is wrong here - there should be a general way of bouncing people to the correct login page, which doesn't have to be reimplemented all over the place. This is, after all, how this used to work, because the framework did the bounce using an attribute. Could we perhaps have the |
I believe this is the commit that introduced this bug: a4b2966#diff-542396835ce4976bb130a2c3363ed972 |
@CatStarwind Yes, you're quite right, that's where it comes from - unfortunately the author of that PR doesn't appear to be around any more. Would you be able to look at my suggestion about fixing this in the Home/Logon action rather than in RepoController/Index (which I think should have as little Auth-specific code in as possible)? |
I remember trying before but being at a loss in trying to find a way without having to import an entire scope. There didn't seem to be a way to check for WindowsAuthenticationProvider in the HomeController. :\ I'll try giving it a second attempt. |
Apologies for the double commit (still not accustomed to using GitHub) but would this work @willdean ? |
Attempt to fix #743 .