Update Somewhere #20
jakubmazanecrelease-pull-request.yaml
on: pull_request
Release pull request
54s
Annotations
2 errors and 10 warnings
|
Release pull request
somewhere#build: command (/home/runner/work/apps/apps/apps/somewhere) /opt/hostedtoolcache/node/20.12.0/x64/bin/npm run build exited (1)
|
|
Release pull request
Process completed with exit code 1.
|
|
Release pull request:
apps/somewhere/app/engine/Entity.ts#L13
Unexpected 'todo:' comment without any conditions: 'TODO: make it work with `ReadonlyMap`'
|
|
Release pull request:
apps/somewhere/app/engine/Entity.ts#L27
Union type constituents must be sorted
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L95
'name' is already declared in the upper scope on line 93 column 37
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L135
Prefer `Node#append()` over `Node#appendChild()`
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L146
Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L216
Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L235
Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`
|
|
Release pull request:
apps/somewhere/app/engine/Game.ts#L285
Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`
|
|
Release pull request:
apps/somewhere/app/engine/GraphicsComponent.ts#L1
All imports in the declaration are only used as types. Use `import type`
|
|
Release pull request:
apps/somewhere/app/engine/Map.ts#L35
`new Error()` is too unspecific for a type check. Use `new TypeError()` instead
|