You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for your great job. Is there any plan to make it compatible with dayjs? It's just like momentjs with the same API but more modern and lightweight.
I would suggest using the core library (https://github.com/jalaali/jalaali-js) to build a new integration rather than changing this one to support 2 libraries, whchi would utterly defeat the purpose. even incompatible with the name (moment-jalaali).
The point is most of momentjs plugins are already compatible. I mean authors do nothing for that because the API is (almost) identical. In fact, the second link above suggests to rename moment to dayjs and that's it. But regarding this repo, I think there is a problem with one or two functions.
even if there were no problem at all. there is no guarantee that things will stay the same. and if things are that similar a simple copy/paste + new repo would be a much better solution. this way we can prevent future divergence should that occur. and it will be easier to track the issues, maintain the project and write tests when they reside in two different repos.
Hi,
First of all, thank you for your great job. Is there any plan to make it compatible with dayjs? It's just like momentjs with the same API but more modern and lightweight.
Take a look here:
https://github.com/iamkun/dayjs
and here:
iamkun/dayjs#529
The text was updated successfully, but these errors were encountered: