Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOCKER.md / more headlines. #2

Open
wants to merge 30 commits into
base: docker-compose-take2
Choose a base branch
from

Conversation

tordans
Copy link

@tordans tordans commented Dec 31, 2020

Split the "run it" and "log inspection" into sections with separate headlines.

However, this might not be the best wording, yet.

Things that might be non ideal, yet:

  • I removed the mix and match-part, since it was not clear to me what the advantage would be …
  • "If you run the app in the foreground the logs of all the 'services' defined in docker-compose.yml will be intermingled." does not clearly say which command to run to see those intermingled logs.

jalessio and others added 30 commits December 30, 2020 14:51
Fails with:
db_1   | Error: Database is uninitialized and superuser password is not specified.
db_1   |        You must specify POSTGRES_PASSWORD for the superuser. Use
db_1   |        "-e POSTGRES_PASSWORD=password" to set it in "docker run".
db_1   |
db_1   |        You may also use POSTGRES_HOST_AUTH_METHOD=trust to allow all connections
db_1   |        without a password. This is *not* recommended. See PostgreSQL
db_1   |        documentation about "trust":
db_1   |        https://www.postgresql.org/docs/current/auth-trust.html

Appears to be related to
docker-library/postgres#681
Co-authored-by: Tobias <t@tobiasjordans.de>
- Added db/functions/functions.sql to docker-compose DB image
- Added `file`, `libgd-dev`, and `unzip` packages to help tests pass
Split the "run it" and "log inspection" sections into separate headlines
@coveralls
Copy link

coveralls commented Dec 31, 2020

Pull Request Test Coverage Report for Build 454679682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.748%

Totals Coverage Status
Change from base Build 453552822: 0.0%
Covered Lines: 6095
Relevant Lines: 6946

💛 - Coveralls

@migurski migurski force-pushed the docker-compose-take2 branch 3 times, most recently from cd5bbe7 to 595fbee Compare January 3, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants