Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary bounds from BinWrite for PhantomData impl #230

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Remove unnecessary bounds from BinWrite for PhantomData impl #230

merged 1 commit into from
Oct 20, 2023

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Oct 20, 2023 •
edited
Loading

Currently BinWrite (but not BinRead) impl for PhantomData<T> requires that T: BinWrite. This is unnecessary, as PhantomData doesn't actually store T and nothing is written.

This PR removes unnecessary trait bound

@jam1garner jam1garner merged commit 21eb49b into jam1garner:master Oct 20, 2023
@DCNick3 DCNick3 deleted the fix-phandomdata-binwrite branch October 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DCNick3 @jam1garner