support X-CID for feature server to detect sip callid #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davehorton
reviewed
Oct 14, 2024
davehorton
requested changes
Oct 14, 2024
lib/call-session.js
Outdated
| // to allow calling/status hooks contains sbc_callid. | ||
| responseHeaders: (uacRes, headers) => { | ||
| if (this.req.locals.cdr) { | ||
| headers['X-CID'] = this.req.locals.cdr.sip_callid; |
There was a problem hiding this comment.
what if this is set
if (this.req.locals.account?.disable_cdrs) {
this.logger.debug('cdrs disabled for this account');
Then won't this.req.locals.cdr not exist, and your code above throw an exception and crash the process?
There was a problem hiding this comment.
I think I was overthinking, the uacRes object will have call-id for the sbc oubound invite.
davehorton
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jambonz/jambonz-feature-server#929