Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename css classes to make integration smoother #146

Closed
antonpinchuk opened this issue May 17, 2013 · 5 comments · Fixed by #213
Closed

Rename css classes to make integration smoother #146

antonpinchuk opened this issue May 17, 2013 · 5 comments · Fixed by #213

Comments

@antonpinchuk
Copy link

Designers and frontend coders often use common words in css class names. That sometimes overlaps nano styles. The default names like .content, .slider could be renamed to something like .n-content, nano-content, nContent etc

@kristerkari
Copy link
Collaborator

This would not be a bad idea, luckily nanoScroller's CSS classes can be changed, so this is not such a big issue.

@antonpinchuk
Copy link
Author

The main idea is to prevent the necessity to patch 3rd party lib in my project just for changing class names

@shyam-habarakada
Copy link

+1

@Majiir
Copy link

Majiir commented Jan 28, 2014

+1. I renamed to nano-pane, nano-slider and nano-content in my own LESS file, but this simply pushes the problem somewhere else because the variable names are @paneClass, @sliderClass and @contentClass! It would be great to see names prefixed across the board.

@aharpervc
Copy link

👍

adam101 pushed a commit to adam101/nanoScrollerJS that referenced this issue Jan 30, 2014
kristerkari pushed a commit that referenced this issue Jan 30, 2014
Add prefix to css class names (fix #146, #208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants