Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD version #266

Closed
SimenB opened this issue Oct 17, 2014 · 3 comments
Closed

AMD version #266

SimenB opened this issue Oct 17, 2014 · 3 comments

Comments

@SimenB
Copy link
Contributor

SimenB commented Oct 17, 2014

Hi!

I really like this plugin, makes things a lot prettier than the fugly default bar. Thank you!

I was wondering if you'd be willing to add an AMD-wrapper to the plugin?

As a by-question, in IE8, when I have a selection and manually drag the scroll... thingy, I lose my selection. Using the scrollwheel works fine. Am I doing something wrong, or won't it work at all?

@kristerkari
Copy link
Collaborator

Yeah for sure we can add a AMD wrapper is there is use for it. Do you want to contribute the wrapper with a pull request?

Your IE8 problem, could it be realted to this bug #244?

@SimenB
Copy link
Contributor Author

SimenB commented Oct 18, 2014

Sure I can provide a PR. I'm not able to run the tests, though.
Running grunt test fails 31 of 34, and deletes a _SpecRunner.html file. Running the SpecRunner.html in test directory in Chrome fails 3 tests. Any idea?

Regarding the bug, I'm not sure, I'd have to test at work on Monday

@kristerkari
Copy link
Collaborator

The CLI test runner is broken at the moment, I need to have a look at that at some point. I need to have a look at the failing tests.

I'm planning to rewrite nanoScroller when I have enough time and motivation, and then I can also do improvements for testing the library.

kristerkari pushed a commit that referenced this issue Oct 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants