Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: numpy 2.0 support #220

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

inoelloc
Copy link
Contributor

Hello,
A pull request to support numpy 2.0

numpy-2-0-python-api-removals

  • Alias np.string_ has been removed. Use np.bytes_ instead.
  • Alias np.unicode_ has been removed. Use np.str_ instead.

numpy-2-0-c-api-removals

  • npy_interrupt.h and the corresponding macros like NPY_SIGINT_ON have been removed.
    Need to include <signal.h> to avoid error: 'SIGINT' undeclared (first use in this function)

I am not sure if the python-package.yml workflow is still useful since the same tests are run inside build-wheels.yml

@smiet
Copy link
Contributor

smiet commented Jun 19, 2024

Should "oldest-supported-numpy" not be removed from the [build-system] in pyproject.toml.

at least it is unneccesary now with numpy 2.0 and the package is deprecated.

@smiet smiet mentioned this pull request Jun 19, 2024
@jameskermode
Copy link
Owner

Thank you very much! I agree with removing oldest-supported-numpy from the dependencies. If you could do that then I'll go ahead and merge.

@inoelloc
Copy link
Contributor Author

python 3.8 will no longer be supported by removing oldest-supported-numpy

@jameskermode
Copy link
Owner

OK, thank you, let's keep Python 3.8 compatibility.

@jameskermode jameskermode merged commit bb895e2 into jameskermode:master Jun 19, 2024
23 checks passed
@inoelloc inoelloc deleted the maint-numpy-2.0 branch June 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants