Skip to content

Commit

Permalink
fix offset-based misses being overcounted in replays
Browse files Browse the repository at this point in the history
  • Loading branch information
poco0317 committed Dec 19, 2022
1 parent 569eec9 commit 47d07db
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Etterna/Models/HighScore/Replay.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3072,6 +3072,7 @@ Replay::GenerateJudgeInfoAndReplaySnapshots(int startingRow, float timingScale)

// Now handle misses and holds.
// For every row in notedata...
tempJudgments[TNS_Miss] = 0; // reset misses :woozy:
FOREACH_NONEMPTY_ROW_ALL_TRACKS(noteData, row)
{
auto tapsMissedInRow = 0;
Expand Down Expand Up @@ -3187,7 +3188,7 @@ Replay::GenerateJudgeInfoAndReplaySnapshots(int startingRow, float timingScale)
// This unfortunately takes more time.
// If current row is recorded in the snapshots, update the counts
if (m_ReplaySnapshotMap.count(row) != 0) {
m_ReplaySnapshotMap[row].judgments[TNS_Miss] =
m_ReplaySnapshotMap[row].judgments[TNS_Miss] +=
tempJudgments[TNS_Miss];
FOREACH_ENUM(HoldNoteScore, hns)
m_ReplaySnapshotMap[row].hns[hns] = tempHNS[hns];
Expand Down

0 comments on commit 47d07db

Please sign in to comment.