Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client pattern #6

Merged
merged 1 commit into from
Feb 20, 2021
Merged

update client pattern #6

merged 1 commit into from
Feb 20, 2021

Conversation

jameslamb
Copy link
Owner

This PR fixes a bunch of small things

  • simplifies installation of LightGBMM
  • gives the base image a meaningful name, and passes it as a build arg to notebook image to reduce duplication
  • moves client keyword into model constructors, because of [dask] remove 'client' kwarg from fit() and predict() (fixes #3808) microsoft/LightGBM#3883
  • added a make clean recipe to clean stuff up
  • removed local.ipynb notebook
  • added a few more PHONY directives in Makefile
  • removed make clone, replaced it with a make target that clones the repo

@jameslamb jameslamb merged commit 025b0ae into main Feb 20, 2021
@jameslamb jameslamb deleted the misc/fixes branch February 20, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jameslamb