Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract alt text from images; add "skip HTML" feature #183

Merged
merged 8 commits into from
Oct 9, 2021

Conversation

jameslittle230
Copy link
Owner

@jameslittle230 jameslittle230 commented May 25, 2021

Closes #148 and closes #186 by replacing the HTML parsing library to one that gives me more control over what part of an HTML page I'm looking at.

Starts foundational work for #159 (in that we can retrieve nearest-ID data now), but to close that issue still requires some JS changes to actually link to those IDs.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #183 (45e11a0) into master (05a0424) will increase coverage by 1.62%.
The diff coverage is 96.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   61.38%   63.00%   +1.62%     
==========================================
  Files          54       54              
  Lines        1893     1987      +94     
  Branches       95       95              
==========================================
+ Hits         1162     1252      +90     
- Misses        731      735       +4     
Flag Coverage Δ
javascript 45.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/config/file.rs 69.23% <ø> (ø)
src/config/mod.rs 81.81% <ø> (ø)
...s/word_list_generators/html_word_list_generator.rs 95.55% <95.57%> (-2.41%) ⬇️
src/index_versions/v3/builder/errors.rs 38.23% <100.00%> (+8.23%) ⬆️
...3/builder/fill_intermediate_entries/frontmatter.rs 93.33% <100.00%> (-0.22%) ⬇️
...rsions/v3/builder/fill_intermediate_entries/mod.rs 88.99% <100.00%> (+0.10%) ⬆️
...rd_list_generators/markdown_word_list_generator.rs 100.00% <100.00%> (ø)
src/index_versions/v3/builder/mod.rs 97.26% <100.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a0424...45e11a0. Read the comment docs.

@jameslittle230 jameslittle230 changed the title Extract alt text from images Extract alt text from images; add "skip HTML" feature Oct 9, 2021
@jameslittle230 jameslittle230 merged commit c1f20dc into master Oct 9, 2021
@jameslittle230 jameslittle230 deleted the 148-img-alt-text branch October 9, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant