Add Introductory Price to InAppBillingProduct #126
Conversation
|
Hey James, |
|
Going to test this for our app, as we need this before we can do a release. Is there no way around needing iOS 11.2 to get these prices? |
|
@marza91 they added the api in 11.2 so it is impossible to have it before any release before that. There really isn't a reason to support anything older than iOS 10: https://data.apteligent.com/ios/ |
| Description = p.LocalizedDescription, | ||
| CurrencyCode = p.PriceLocale?.CurrencyCode ?? string.Empty, | ||
| LocalizedIntroductoryPrice = operatingSystemHasIntroductoryPrice && p.IntroductoryPrice != null ? p.IntroductoryPrice.LocalizedPrice() : "", | ||
| MicrosIntroductoryPrice = operatingSystemHasIntroductoryPrice && p.IntroductoryPrice != null ? (long)(p.Price.DoubleValue * 1000000d) : 0 |
There was a problem hiding this comment.
shouldn't this be looking at p.IntroductoryPrice.DoubleValue?
There was a problem hiding this comment.
maybe we should refactor this into a common method?
| Description = p.LocalizedDescription, | ||
| CurrencyCode = p.PriceLocale?.CurrencyCode ?? string.Empty | ||
| }); | ||
| var operatingSystemHasIntroductoryPrice = NSProcessInfo.ProcessInfo.IsOperatingSystemAtLeastVersion(new NSOperatingSystemVersion(11, 2, 0)); |
There was a problem hiding this comment.
This is wrong. Put it at the class level:
bool IsiOS112 => UIDevice.CurrentDevice.CheckSystemVersion (11,2);
|
Added a few more required tweaks to this one |
…heck valid introductoryprice
|
Hey James, I have updated the PR, an extension method is now used to check whether an introduction price can be used and I have updated the DoubleValue to target the correct value. |
|
Any changes or anything needed for UWP? |
|
No changes are needed for UWP, the InAppBillingProduct will say no IntroductoryPrice is available, according to the microsoft documentation I do not see any reference to an introductory price, only if the item is on sale or not but this is not the same as an introductory price. |
Please take a moment to fill out the following:
Fixes #123 .
Changes Proposed in this pull request: