-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android subscriptions downgrade / upgrade (Google Play Billing Library 4.0.0 c… #404
Android subscriptions downgrade / upgrade (Google Play Billing Library 4.0.0 c… #404
Conversation
@jamesmontemagno This is new version of #350 , but compatible with Google Play Billing Library 4.0.0 (and based on latest plugin version) |
Nice, i'll look and pull it in. Does iOS have similar functionality at all? |
On iOS, this is managed differently. You can create subscription groups, if a user buys a new subscription from the same group, the old subscription is automatically upgraded / downgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using something very close to this outside of the plugin package, so it will be nice to have it included in the main package.
@codexguy any code review? look good and useful to you? |
I did take a look with an eye towards matching something similar I had done in a clone, so I would say "reviewed", yes. |
@jamesmontemagno any chance for marge soon? |
Was out on holiday a bit, let me put this on my list for this week. |
@RadoslawKubas take a look at my changes and le me know if that is cool, should be easy peasy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect 👍
Hello @jamesmontemagno , do you have maybe any idea when plugin version with this merge will be released to public? |
Fixes #26
Changes Proposed in this pull request:
New UpgradePurchasedSubscriptionAsync function is implemented for Android. It uses similar interface as #192 but implementation works fine with latest api (Google Play Billing Library 4.0.0). Implementation for iOS is not necessary, because iOS support upgrades/downgrades itself. I didn't check UWP.