-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MonkeyCache to 2.0 and use System.Text.Json #109
Conversation
- Drop Newtonsoft and use System.Text.Json instead - Allow for source generators to be used in IBarrel - Drop Xamarin TFMs and just target net6.0 - Mark MonkeyCache assemblies as IsTrimmable=true, so unused code can be trimmed
4ede7a8
to
6363e9e
Compare
There is only one place that needs OS specific APIs in BarrelUtils. So only the main MonkeyCache.csproj needs to be multi-targeted.
You'll want to review this with whitespace ignored. I formatted the .csprojs because there was a mix of tabs vs spaces in them. |
@eerhardt we should probably write some docs on this..... |
Definitely can do. Do we have docs for MonkeyCache somewhere? The root Readme good enough? |
Yeah readme is good enough:) |
Why their are some nice additions in netown soft why do companies not reach out to developers first before removing stuff |
@davidbuckleyni - can you explain a little bit more? You can still use Newtonsoft to serialize your objects yourself and put them into the Barrel as The biggest reasons for moving to System.Text.Json in this library are:
Newtonsoft does have capabilities that System.Text.Json doesn't. But the issue with keeping a reference to Newtonsoft is that Newtonsoft isn't marked as a "Trimmable" assembly. So if you reference it anywhere in your app (even if the code referencing it is trimmed), the whole assembly and anything it references are preserved in your app. This causes bloat in your apps. |
@jamesmontemagno