Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ Fix and test for #338 #340

Merged
merged 2 commits into from
Jan 13, 2022
Merged

+ Fix and test for #338 #340

merged 2 commits into from
Jan 13, 2022

Conversation

raedma
Copy link

@raedma raedma commented Jan 11, 2022

@PeriDoX
+ Fix from https://github.com/jamesmudd/jhdf/tree/issue-338
52f0fb1 
+ Test for issue compound scalar attribute case
@raedma raedma changed the title + Fix and test for #337 + Fix and test for #338 Jan 11, 2022
@jamesmudd
Copy link
Owner

Thanks this looks great. Could you fix the formatting issues so the CI can pass e.g. 60263c0

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jamesmudd jamesmudd merged commit f601647 into jamesmudd:master Jan 13, 2022
@jamesmudd
Copy link
Owner

Thanks a lot for this. I will look to make a release soon including this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raedma @jamesmudd @PeriDoX