Prevent race condition when using requests_futures and ThreadPoolExecutor #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
requests_future.Session
and aThreadPoolExecutor
there is a race condition where one thread removes the monkeypatchedsession.get_adapter()
method before another thread has finished using it. This results in the losing thread mistakenly using the real requests adapters and likely executing a real http request.This PR wraps the monkeypatching logic in a
threading.Lock
to prevent multiple requests racing either other.Given that other
session
methods are monkeypatched it's possible there are other race conditions in threading contexts, but making requests_mock completely thread-safe is beyond the scope of this PR.