-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI --serverinfo: Add ISO country code support in addition to Qt Country IDs #2362
Comments
The current Locale -> Country letter method could possibly be used in reverse: take a two letter country code ( If I've understood it correctly. I could be wrong... |
For FooCountry, I think we should use the international standard abbreviations, rather than names, as defined in ISO-3316. Either the 2-letter or 3-letter variants (we could accept both). It then becomes independent of language, which could complicate things if we tried to interpret country names (e.g. Germany/Deutschland/Allemagne, Holland/Netherlands/Nederland, Belgium/Belgien/Belgie) |
After updating to 3.9.0 and Qt6, the country of my server changed without any changes to the config, apparently it is using Qt6 Country IDs now. I fixed it by updating to the new code in this list: https://doc.qt.io/qt-6/qlocale.html#Country-enum Agree it would be more user friendly to specify country names/codes. |
Thanks for the report! This is unintended. I've opened #2809 to investigate this with rather high priority as it would be a regression. |
With this change, --serverinfo supports two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
I've prepared a branch which adds support for two-letter ISO country codes here: hoffie@serverinfo-two-letter-country-codes Will submit after #2829 is merged as the branch is based on that PR. |
With this change, --serverinfo supports two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
With this change, --serverinfo gains support for two-letter ISO country codes such as "de", "gb", "nl", "fr". Numeric Qt5-style codes keep working as expected. Fixes: jamulussoftware#2362
Currently,
--serverinfo
requires users to specify Qt Country IDs. This is not user-friendly.With Qt6,
--serverinfo
will require users to specify Qt5 Country IDs, even if they are on Qt6. This is really not user-friendly.Has this feature been discussed and generally agreed?
The ugliness of the status quo, especially when adding support for Qt6, has been officially stated by @pljones here: #2299 (review) :)
Describe the solution you'd like
--serverinfo
should support ISO country codes, e.g.--serverinfo 'FooServer;FooCity;de
We should still keep support for the numerical IDs for compatibility.
The text was updated successfully, but these errors were encountered: