Remove sh -c #1517
Closed
Remove sh -c #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `sh -c`
Update directory address
hoffie
reviewed
Apr 14, 2021
| @@ -8,7 +8,7 @@ Type=simple | |||
| Restart=always | |||
| RestartSec=1 | |||
| User=jamulus | |||
| ExecStart=/bin/sh -c '/usr/bin/jamulus -s -n -l /var/log/jamulus -e jamulus.fischvolk.de -g -o "$(uname -n);;"' | |||
| ExecStart=/usr/bin/jamulus -s -n -l /var/log/jamulus -e anygenre1.jamulus.io:22124 -g -o "$(uname -n);;" | |||
There was a problem hiding this comment.
I suspect $(uname -n) will not expand properly without the sh -c wrap. This would likely need the exec as @softins suggested (haven't tried myself):
Suggested change
| ExecStart=/usr/bin/jamulus -s -n -l /var/log/jamulus -e anygenre1.jamulus.io:22124 -g -o "$(uname -n);;" | |
| ExecStart=/bin/sh -c 'exec /usr/bin/jamulus -s -n -l /var/log/jamulus -e anygenre1.jamulus.io:22124 -g -o "$(uname -n);;"' |
There was a problem hiding this comment.
I would expect it to be OK since it's not a sh only thing. Putting sh -c back here will cause the problem with SIGUSR2, no?
There was a problem hiding this comment.
I wasn't aware of the second file. @hoffie suggested change will work. I already tested it with SIGUSR2.
There was a problem hiding this comment.
If I read https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Specifiers correctly
ExecStart=/usr/bin/jamulus -s -n -l /var/log/jamulus -e anygenre1.jamulus.io:22124 -g -o %H
would work.
helgeerbe
approved these changes
Apr 14, 2021
softins
requested changes
Apr 14, 2021
|
@softins I see you're going to do that so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1515 (comment)