-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github issue template for new releases and update release tooling #1594
Add Github issue template for new releases and update release tooling #1594
Conversation
e175894
to
d98ae8b
Compare
BTW turning off comments for release announcements is a learning from SourceForge, as such announcements would sometimes turn into mini-forum of random tech support requests, complaints, "thanks" and other things that should have been opened as separate discussions. |
For the release, yes. Not for nightlies, betas and candidates, though - it's better to keep the discussions on the same thread as the announcement for those, really. You don't want the forum overrun with odd posts that may relate to an out of date RC being followed up a week later with a "So what's been done about it?" because no one spotted it - or because the raiser didn't see that it had been fixed in the new RC, etc. |
d4401ef
to
a5a4fee
Compare
Until other documentation changes intervene, we need a step here to check |
a5a4fee
to
dcbcd02
Compare
Good idea. Added that after code freeze and before starting translations. |
f38018e
to
feff9b8
Compare
I have updated the checklist in several places, especially around translations. I have also added automation for creating the translation tickets as part of this PR. |
6fc1e6f
to
9cc9acb
Compare
Updated again. The script for generating the issues can now handle website translations as well. |
ec0a2c6
to
9d886bd
Compare
9d886bd
to
cab816a
Compare
I'd say so -- in case the wording has to change as part of fixing the link. |
f8732aa
to
1be3eb8
Compare
Updated. |
|
||
Please | ||
|
||
- Start your work in your fork on a branch based on jamuluswebsite'"'"'s `${TRANSLATE_BRANCH}` branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Start your work in your fork on a branch based on jamuluswebsite'"'"'s ``${TRANSLATE_BRANCH}`` branch.
The app
version is already clearer... This needs to make it clear that local fork's master needs updating from jamulussoftware/jamuluswebsite master, then the local ${TRANSLATE_BRANCH}
branch updated, and then work started on a branch from the ${TRANSLATE_BRANCH}
branch. If I've understood the process right...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no master
in the website repo (release
would be the most similar branch). However, ${TRANSLATE_BRANCH}
is the only branch which translators should have to care about (well, 3.8.0 was different for $REASONS...). This branch is a one-time branch (e.g. translate3_8_0
), so there should be no need to update/rebase.
As the process is supposed to be reworked regarding tooling (po4a) and branching, I'd like to keep it like this for now.
(cc @ignotus666 @ann0see @gilgongo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, if it's all going to change, no problem. (However, make whatever's written clear enough that a first time translator will be able to read it and know what steps to follow.)
@@ -0,0 +1,216 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a lovely bit of bash :)
8e36338
to
66648a5
Compare
There's still something for the website (delete translate branch) |
66648a5
to
1b21e18
Compare
Added now. |
b44789b
to
36224e8
Compare
* Adds release_new_version ISSUE_TEMPLATE * Adds create-translation-issues.sh helper script * Updates get_release_contributors.py to support Co-authored-by lines (fixes jamulussoftware#1599) Co-authored-by: Jonathan <4561747+gilgongo@users.noreply.github.com> Co-authored-by: Peter L Jones <pljones@users.noreply.github.com> Co-authored-by: ann0see <20726856+ann0see@users.noreply.github.com>
36224e8
to
644f1c7
Compare
@jamulussoftware/maindevelopers shouldn‘t this be Part of 3.8.1 too (at least the scripts)? |
|
I've uploaded the issue template on the website, so this should be removed. Everything else should be ok? |
The template is now on https://jamulus.io/contribute/Release-Process
This PR adds the release checklist as an issue template so that we can easily create new Issues based on that.
The checklist is a slightly improved version of what we had for 3.7.0.
I'm still planning to perform some updates and possibly add a template for translations as well. I'm therefore setting this to Draft status right now. Feel free to provide feedback regarding the existing content or the process itself though.