Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github issue template for new releases and update release tooling #1594

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

hoffie
Copy link
Member

@hoffie hoffie commented May 1, 2021

This PR adds the release checklist as an issue template so that we can easily create new Issues based on that.

The checklist is a slightly improved version of what we had for 3.7.0.

I'm still planning to perform some updates and possibly add a template for translations as well. I'm therefore setting this to Draft status right now. Feel free to provide feedback regarding the existing content or the process itself though.

@hoffie hoffie marked this pull request as draft May 1, 2021 19:29
@hoffie hoffie mentioned this pull request May 1, 2021
50 tasks
@hoffie hoffie force-pushed the release-issue-template branch 4 times, most recently from e175894 to d98ae8b Compare May 1, 2021 22:36
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_new_version.md Outdated Show resolved Hide resolved
@gilgongo
Copy link
Member

gilgongo commented May 2, 2021

BTW turning off comments for release announcements is a learning from SourceForge, as such announcements would sometimes turn into mini-forum of random tech support requests, complaints, "thanks" and other things that should have been opened as separate discussions.

@pljones
Copy link
Collaborator

pljones commented May 2, 2021

BTW turning off comments for release announcements is a learning from SourceForge, as such announcements would sometimes turn into mini-forum of random tech support requests, complaints, "thanks" and other things that should have been opened as separate discussions.

For the release, yes. Not for nightlies, betas and candidates, though - it's better to keep the discussions on the same thread as the announcement for those, really. You don't want the forum overrun with odd posts that may relate to an out of date RC being followed up a week later with a "So what's been done about it?" because no one spotted it - or because the raiser didn't see that it had been fixed in the new RC, etc.

@pljones
Copy link
Collaborator

pljones commented May 2, 2021

Until other documentation changes intervene, we need a step here to check ./Jamulus -h output against the en-Command-Line-Options.md wiki page.

@hoffie
Copy link
Member Author

hoffie commented May 2, 2021

Until other documentation changes intervene, we need a step here to check ./Jamulus -h output against the en-Command-Line-Options.md wiki page.

Good idea. Added that after code freeze and before starting translations.

@hoffie hoffie force-pushed the release-issue-template branch 4 times, most recently from f38018e to feff9b8 Compare May 3, 2021 21:47
@hoffie
Copy link
Member Author

hoffie commented May 3, 2021

I have updated the checklist in several places, especially around translations. I have also added automation for creating the translation tickets as part of this PR.

@hoffie hoffie force-pushed the release-issue-template branch 4 times, most recently from 6fc1e6f to 9cc9acb Compare May 4, 2021 20:29
@hoffie
Copy link
Member Author

hoffie commented May 4, 2021

Updated again. The script for generating the issues can now handle website translations as well.

@hoffie hoffie force-pushed the release-issue-template branch 4 times, most recently from ec0a2c6 to 9d886bd Compare May 8, 2021 19:59
@pljones
Copy link
Collaborator

pljones commented May 28, 2021

Does it also make sense to run this before pinging translators?

I'd say so -- in case the wording has to change as part of fixing the link.

@hoffie
Copy link
Member Author

hoffie commented Jun 1, 2021

Does it also make sense to run this before pinging translators?

I'd say so -- in case the wording has to change as part of fixing the link.

Updated.

@hoffie hoffie requested a review from pljones June 1, 2021 05:16

Please

- Start your work in your fork on a branch based on jamuluswebsite'"'"'s `${TRANSLATE_BRANCH}` branch.
Copy link
Collaborator

@pljones pljones Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Start your work in your fork on a branch based on jamuluswebsite'"'"'s ``${TRANSLATE_BRANCH}`` branch.

The app version is already clearer... This needs to make it clear that local fork's master needs updating from jamulussoftware/jamuluswebsite master, then the local ${TRANSLATE_BRANCH} branch updated, and then work started on a branch from the ${TRANSLATE_BRANCH} branch. If I've understood the process right...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no master in the website repo (release would be the most similar branch). However, ${TRANSLATE_BRANCH} is the only branch which translators should have to care about (well, 3.8.0 was different for $REASONS...). This branch is a one-time branch (e.g. translate3_8_0), so there should be no need to update/rebase.
As the process is supposed to be reworked regarding tooling (po4a) and branching, I'd like to keep it like this for now.

(cc @ignotus666 @ann0see @gilgongo)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, if it's all going to change, no problem. (However, make whatever's written clear enough that a first time translator will be able to read it and know what steps to follow.)

@@ -0,0 +1,216 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a lovely bit of bash :)

@hoffie hoffie force-pushed the release-issue-template branch 3 times, most recently from 8e36338 to 66648a5 Compare June 2, 2021 18:57
@ann0see
Copy link
Member

ann0see commented Jun 2, 2021

There's still something for the website (delete translate branch)

@hoffie
Copy link
Member Author

hoffie commented Jun 2, 2021

There's still something for the website (delete translate branch)

Added now.

@hoffie hoffie force-pushed the release-issue-template branch 2 times, most recently from b44789b to 36224e8 Compare June 6, 2021 10:33
* Adds release_new_version ISSUE_TEMPLATE
* Adds create-translation-issues.sh helper script
* Updates get_release_contributors.py to support Co-authored-by lines (fixes jamulussoftware#1599)

Co-authored-by: Jonathan <4561747+gilgongo@users.noreply.github.com>
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
Co-authored-by: ann0see <20726856+ann0see@users.noreply.github.com>
@ann0see
Copy link
Member

ann0see commented Sep 7, 2021

@jamulussoftware/maindevelopers shouldn‘t this be Part of 3.8.1 too (at least the scripts)?

@pljones
Copy link
Collaborator

pljones commented Sep 7, 2021

@jamulussoftware/maindevelopers shouldn‘t this be Part of 3.8.1 too (at least the scripts)?

  • is it what we're following for 3.8.1?
  • if not, why not? (i.e. what needs to change in what we're doing or what needs changing in this?)
  • if so, yes and merge it.

@ann0see
Copy link
Member

ann0see commented Sep 7, 2021

I've uploaded the issue template on the website, so this should be removed. Everything else should be ok?

@ann0see ann0see mentioned this pull request Sep 9, 2021
57 tasks
@gilgongo gilgongo merged commit c74b032 into jamulussoftware:master Sep 10, 2021
@pljones pljones added this to the Release 3.8.1 milestone Feb 19, 2022
@hoffie hoffie deleted the release-issue-template branch March 19, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools/get_release_contributors.py: Add Co-authored-by support
4 participants