-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unclear error message made precise #1978
Conversation
unclear error message made precise #1967.
…r-message-made-precise unclear error message made precise
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Merge should not be here. Ignore it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do a squash merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple ;-). Thanks
@DavidSavinkoff Could you please also give a proposal for the ChangeLog? |
My proposals for the ChangeLog are: I think (1) is better. |
Yep, will use (1). |
Short description of changes
At line 1047, or nearby, in jamulus/master/src/main.cpp:
QString errmsg = "%1: '%2' needs a numeric argument between '%3' and '%4'.";
Should be rewritten in the Queen's English to be:
QString errmsg = "%1: '%2' needs a numeric argument from '%3' to '%4'.";
In order to be mathematically correct in English.
This fixes the meaning in all places where this message ocurrs.
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist