Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear error message made precise #1978

Merged
merged 2 commits into from Aug 31, 2021
Merged

unclear error message made precise #1978

merged 2 commits into from Aug 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2021

Short description of changes

At line 1047, or nearby, in jamulus/master/src/main.cpp:
QString errmsg = "%1: '%2' needs a numeric argument between '%3' and '%4'.";
Should be rewritten in the Queen's English to be:
QString errmsg = "%1: '%2' needs a numeric argument from '%3' to '%4'.";
In order to be mathematically correct in English.
This fixes the meaning in all places where this message ocurrs.
Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

DavidSavinkoff added 2 commits August 26, 2021 06:25
unclear error message made precise #1967.
…r-message-made-precise

unclear error message made precise
@ghost
Copy link
Author

ghost commented Aug 26, 2021

  • Please consider this PR.
  • The Windows artifact failure is not my fault (must be problem with your build system).
  • Thank you

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Merge should not be here. Ignore it.

@ann0see ann0see requested a review from gilgongo August 29, 2021 10:51
@ann0see ann0see linked an issue Aug 29, 2021 that may be closed by this pull request
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do a squash merge

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple ;-). Thanks

@ann0see ann0see added this to the Release 3.8.1 milestone Aug 31, 2021
@ann0see ann0see merged commit f09ed98 into jamulussoftware:master Aug 31, 2021
@ann0see
Copy link
Member

ann0see commented Aug 31, 2021

@DavidSavinkoff Could you please also give a proposal for the ChangeLog?

@ghost
Copy link
Author

ghost commented Aug 31, 2021

My proposals for the ChangeLog are:
1)Number range command line error messages reworded accurately.
2)Command line error messages from GetNumericArgument() of the form:
{variable} needs a numeric argument between {low value} and {high value}.
corrected to:
{variable} needs a numeric argument from {low value} to {high value}.

I think (1) is better.

@ann0see
Copy link
Member

ann0see commented Sep 1, 2021

Yep, will use (1).

ann0see added a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unclear error message made precise
2 participants