Android update replacing PR #1528 #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
approved these changes
Jan 13, 2022
|
Not tested yet,.. |
|
Not quite sure if it's a problem with the windows 11 subsystem for android, but I couldn't hear any sound. But to be honest, it's not the way to correctly test the app ;-). Also it seems to be unstable. But I'd say that's expected for beta software. |
Was fine on my phone just now. Listened to a session for a while. Little bit of bubbling in the sound, but that could easily have been my wifi or one of the participants. |
|
Hmm. Probably gonna approve it then. |
ann0see
approved these changes
Jan 13, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Rebased and squashed version of @j-santander PR #1528, with a few additional corrections.
Context: Fixes an issue?
The original PR #1528 has been waiting for some months, but it was based on the submitter's
masterbranch. Rather than pushing updates to hismaster, I created a new branch in my own repo. Can close #1528.Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Built successfully on Ubuntu20 and tried out on my Android phone. Looks ok.
What is missing until this pull request can be merged?
Ready to merge, although the Android port needs more work in general.
Checklist